feat(core) Add preferred transport changed event#3320
Open
yrb wants to merge 1 commit intozmkfirmware:mainfrom
Open
feat(core) Add preferred transport changed event#3320yrb wants to merge 1 commit intozmkfirmware:mainfrom
yrb wants to merge 1 commit intozmkfirmware:mainfrom
Conversation
snoyer
reviewed
Apr 6, 2026
Contributor
snoyer
left a comment
snoyer
left a comment
There was a problem hiding this comment.
Thanks! I tested with a custom display and it does solve the use-case of notifying when going between &out OUT_BLE and &out OUT_USB while only one of USB or BLE is available (meaning the active endpoint has nothing to change to, as mentioned in the description, and therefore no existing endpoint_changed event is fired).
Hopefully @joelspadin can do an actual review
Added an event for the preferred transport changing, this is primarily to trigger display updates.
yrb
force-pushed
the
preferred_transport_changed_event
branch
from
bdc1ab8 to
fe3bba3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an event on preferred transport changing. The primary use of this is to drive display updates in the case the preferred transport changes but the active endpoint does not change.
PR check-list